<html>
<head><meta charset="utf-8"><title>&#x27;Manual crater run&#x27; results · edition 2021 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/index.html">edition 2021</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html">&#x27;Manual crater run&#x27; results</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="244166518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244166518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244166518">(Jun 28 2021 at 15:58)</a>:</h4>
<p>Starting this thread to dump results in from trying the migrations and new edition manually on some code. (cc <span class="user-mention" data-user-id="224872">@rylev</span> for the top 10 most popular crates)</p>



<a name="244166619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244166619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244166619">(Jun 28 2021 at 15:59)</a>:</h4>
<p>I tried out the migration lints on some of my own code, and ran into one false positive:</p>
<ul>
<li>A <code>StructOpt</code> struct being used with <code>Opt::from_iter</code></li>
</ul>
<div class="codehilite"><pre><span></span><code> help: disambiguate the associated function: `&lt;Opt as StructOpt&gt;::from_iter`
</code></pre></div>
<p>This doesn't actually become ambiguous when FromIterator is imported, because Opt doesn't implement that.</p>



<a name="244166725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244166725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244166725">(Jun 28 2021 at 15:59)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="322737">@jam1garner</span> i think that's the expected behaviour?</p>



<a name="244167101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> jam1garner <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167101">(Jun 28 2021 at 16:00)</a>:</h4>
<p>Hm. Yes, I was under the impression it raised an error even if the trait wasn’t implemented by the type?</p>



<a name="244167392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167392">(Jun 28 2021 at 16:02)</a>:</h4>
<p>we could change that if we wanted</p>



<a name="244167422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167422">(Jun 28 2021 at 16:02)</a>:</h4>
<p>the trait does have to be implemented though</p>



<a name="244167441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167441">(Jun 28 2021 at 16:03)</a>:</h4>
<p>that is, the compiler won't consider it ambiguous if you don't implement the trait</p>



<a name="244167504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> jam1garner <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167504">(Jun 28 2021 at 16:03)</a>:</h4>
<p>If that’s wrong though (which seems like it is from the playground) I don’t think that’s actually too hard to fix</p>



<a name="244167665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244167665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244167665">(Jun 28 2021 at 16:04)</a>:</h4>
<p>shouldn't be that hard, we just need a call to <code>evaluate_predicate</code> I think</p>



<a name="244439161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244439161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244439161">(Jun 30 2021 at 15:12)</a>:</h4>
<p>Running these now. I find the error message from new resolver to be a bit confusing. </p>
<div class="codehilite"><pre><span></span><code>The following differences were detected with the current configuration:

  proc-macro2 v1.0.27 removed features `default`
</code></pre></div>
<p>What is this trying to tell me? This looks as if I had updated to a new version of proc-macro2 and it removed the feature <code>default</code>, but that's not what's happening.</p>



<a name="244439183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244439183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244439183">(Jun 30 2021 at 15:12)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="120518">@Eric Huss</span> ^^</p>



<a name="244440080"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244440080" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244440080">(Jun 30 2021 at 15:18)</a>:</h4>
<p>I've also run into an issue migrating <code>proc-macro2</code> where one of the benchmarks does not compile. It also seems to not compile before the migration, but I do wonder if failing to compile a piece of a crate should make the entire process error. If my crate's tests don't compile, this means my examples won't be migrated. Is that what we wnat?</p>



<a name="244442513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244442513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244442513">(Jun 30 2021 at 15:32)</a>:</h4>
<p>Looks like we have an issue in <code>serde</code>. <code>serde</code> is currently on Rust 2015. I can update from 2015 to 2018 fine. But when I run <code>cargo fix</code> again, it doesn't seem to pick up the <code>dyn</code> changes. This works in a dummy crate I've created so it's definitely not just a simple case of unimplemented feature.</p>



<a name="244447838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244447838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244447838">(Jun 30 2021 at 16:07)</a>:</h4>
<p>Looks like tokio experiences an ICE when running cargo fix. I'm going to start filing issues.</p>



<a name="244450567"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244450567" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244450567">(Jun 30 2021 at 16:25)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/86751">https://github.com/rust-lang/rust/issues/86751</a> - serde failure<br>
<a href="https://github.com/rust-lang/rust/issues/86753">https://github.com/rust-lang/rust/issues/86753</a> - tokio ICE</p>



<a name="244450881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244450881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244450881">(Jun 30 2021 at 16:27)</a>:</h4>
<p>(the tokio ICE looks like <a href="https://github.com/rust-lang/rust/issues/86743">https://github.com/rust-lang/rust/issues/86743</a> which has no actionable info yet)</p>



<a name="244591677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244591677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244591677">(Jul 01 2021 at 16:16)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> the mini-crater run has shown that by far the closure captures migration is the one that gets triggered the most. Would you be able to look at some of the diffs and see if they look correct to you?</p>



<a name="244592191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244592191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244592191">(Jul 01 2021 at 16:20)</a>:</h4>
<p>Here are some I collected: <a href="/user_uploads/4715/bw1Pr9bOffpwRHtQu6VJgKoC/diffs.zip">diffs.zip</a></p>



<a name="244603327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244603327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244603327">(Jul 01 2021 at 17:49)</a>:</h4>
<p>Yep! I just remembered that we found some pretty severe bugs that we were talking about fixing yesterday</p>



<a name="244603387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244603387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244603387">(Jul 01 2021 at 17:49)</a>:</h4>
<p>notably <a href="https://github.com/rust-lang/project-rfc-2229/issues/51">https://github.com/rust-lang/project-rfc-2229/issues/51</a></p>



<a name="244603398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/244603398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#244603398">(Jul 01 2021 at 17:49)</a>:</h4>
<p>should add that to the project board too</p>



<a name="245455675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245455675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245455675">(Jul 09 2021 at 15:11)</a>:</h4>
<p>The initial crates that were having issues have been resolved. I'm going to run a bit larger of a group now (top 100 crates), and see if there are any other issues</p>



<a name="245469744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245469744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245469744">(Jul 09 2021 at 17:05)</a>:</h4>
<p>Seeing an issue when trying to upgrade the serde workspace - serde derive seems to fail though when I run <code>cargo fix</code> directly on serde_derive it works:</p>
<div class="codehilite"><pre><span></span><code> cargo +nightly fix --edition
   Compiling serde_derive v1.0.126 (/home/rylevick/code/mini-crater/serde/serde_derive)
   Compiling serde_derive_internals v0.26.0 (/home/rylevick/code/mini-crater/serde/serde_derive_internals)
   Migrating serde_derive_internals/lib.rs from 2015 edition to 2018
   Migrating serde_derive/src/lib.rs from 2015 edition to 2018
       Fixed serde_derive_internals/src/receiver.rs (1 fix)
       Fixed serde_derive_internals/lib.rs (1 fix)
       Fixed serde_derive_internals/src/attr.rs (4 fixes)
       Fixed serde_derive_internals/src/ast.rs (3 fixes)
       Fixed serde_derive_internals/src/check.rs (3 fixes)
warning: failed to automatically apply fixes suggested by rustc to crate `serde_derive`

after fixes were automatically applied the compiler reported errors within these files:

  * serde_derive/src/internals/ast.rs
  * serde_derive/src/internals/attr.rs
  * serde_derive/src/internals/check.rs
  * serde_derive/src/internals/receiver.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You&#39;re likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/rust/issues
quoting the full output of this command we&#39;d be very appreciative!
Note that you may be able to make some more progress in the near-term
fixing code with the `--broken-code` flag

The following errors were reported:
error: expected `;`, found `rnals`
 --&gt; serde_derive/src/internals/ast.rs:3:94
  |
3 | use crate::internals::attrs::attcrate::internals::checkternalcrate::internals::{Ctxt, Derive}rnals::{Ctxt, Derive};
  |                                                                                              ^^^^^ expected `;`
  |
  = note: glob-like brace syntax must be last on the path

error: expected one of `::`, `;`, or `as`, found `:`
 --&gt; serde_derive/src/internals/attr.rs:1:37
  |
1 | use crate::internals::respan::respan:respacrate::internals::symbol::*als::scrate::internals::{ungroup, Ctxt}nals::{ungroup, Ctxt};
  |                                     ^ expected one of `::`, `;`, or `as`

error: expected one of `::`, `;`, or `as`, found `:`
 --&gt; serde_derive/src/internals/receiver.rs:1:37
  |
1 | use crate::internals::respan::respan:respan;
  |                                     ^ expected one of `::`, `;`, or `as`

error: unexpected closing delimiter: `}`
 --&gt; serde_derive/src/internals/check.rs:1:177
  |
1 | ...gType}fier, crate::internals::{ungroup, Ctxt, Derive}ngroup, Ctxt, Derive};
  |                                  -                     -                    ^ unexpected closing delimiter
  |                                  |                     |
  |                                  |                     ...matches this closing brace
  |                                  this opening brace...

error: aborting due to 4 previous errors

Original diagnostics will follow.
</code></pre></div>



<a name="245469795"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245469795" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245469795">(Jul 09 2021 at 17:06)</a>:</h4>
<p>Unfortunately, I don't have time to look deeper now, but I'll try to take a look as soon as I can</p>



<a name="245469882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245469882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245469882">(Jul 09 2021 at 17:06)</a>:</h4>
<p>If you'd like to see the full mini-crater run you can here:</p>



<a name="245469889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245469889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245469889">(Jul 09 2021 at 17:06)</a>:</h4>
<p><a href="/user_uploads/4715/cq6RvQKkMZfi5GA1_Z-9W33N/logs.zip">logs.zip</a></p>



<a name="245476830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245476830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245476830">(Jul 09 2021 at 18:01)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> This is a known issue (<a href="https://github.com/rust-lang/cargo/issues/6528">https://github.com/rust-lang/cargo/issues/6528</a>). The problem is that the same source file is included in multiple crates (via <a href="https://github.com/serde-rs/serde/blob/9c39115f827170f7adbdfa4115f5916c5979393c/serde_derive_internals/lib.rs#L43-L45">here</a>).  Two concurrent executions try to modify the same file at the same time, causing corruption.  The solution is to migrate one package at a time.</p>



<a name="245488206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245488206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245488206">(Jul 09 2021 at 19:42)</a>:</h4>
<p><span class="user-mention silent" data-user-id="224872">rylev</span> <a href="#narrow/stream/268952-edition-2021/topic/'Manual.20crater.20run'.20results/near/245455675">said</a>:</p>
<blockquote>
<p>The initial crates that were having issues have been resolved. I'm going to run a bit larger of a group now (top 100 crates), and see if there are any other issues</p>
</blockquote>
<p>Yay!</p>



<a name="245501009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245501009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Pratt <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245501009">(Jul 09 2021 at 21:16)</a>:</h4>
<p>^^ keep in mind that the test suite for a crate may only work when certain features are enabled. For the time crate I gave up on trying to match the flags a while back, so <code>--all-features</code> is required to be passed.</p>



<a name="245501171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245501171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jacob Pratt <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245501171">(Jul 09 2021 at 21:17)</a>:</h4>
<p>at least for the time crate, it runs fine, though it doesn't change anything.</p>



<a name="245582027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245582027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245582027">(Jul 11 2021 at 01:51)</a>:</h4>
<p>Posted <a href="https://github.com/rust-lang/cargo/pull/9677">https://github.com/rust-lang/cargo/pull/9677</a> to fix the serde workspace issue.</p>



<a name="245721797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245721797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245721797">(Jul 12 2021 at 17:49)</a>:</h4>
<p>One very small "issue" I've noticed with the closure capture migration is that it adds a line on the same line as the beginning of the closure even if the body starts on the same line. I assume we just want to rely on rustfmt to take care of that, but I thought it worth mentioning.</p>



<a name="245722680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245722680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245722680">(Jul 12 2021 at 17:55)</a>:</h4>
<p>I'm going to close the mini-crater issue as I think it's done. We've captured everything we can at this point and should focus on the full crater run.</p>



<a name="245724886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245724886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245724886">(Jul 12 2021 at 18:10)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> yes we planned in relying on rustfmt</p>



<a name="245734079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/268952-edition%202021/topic/%27Manual%20crater%20run%27%20results/near/245734079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/268952-edition-2021/topic/&#x27;Manual.20crater.20run&#x27;.20results.html#245734079">(Jul 12 2021 at 19:15)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> great!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>